Wireshark-commits: [Wireshark-commits] master cf5b867: Adding the missing generic method to support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Apr 2019 06:09:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cf5b86721ae904601d1a501b126ab5f782f6d167
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

cf5b867 by Dr. Lars Voelker (lars-github@xxxxxxxxxxxxxx):

    Adding the missing generic method to support multiple vendor-defined ext types
    
    The current EAP dissector assumes that all vendor-defined extended types are
    WPS. This does not allow for adding new vendor-defined payloads. This codes
    cleans up the limitation. The Vendor-ID can be registered using a dissector
    table, while the Vendor-Type is passed as data.
    
    Change-Id: Idc75108fd42b9b2153089db503b137c6eeefe274
    Signed-off-by: Dr. Lars Voelker <lars-github@xxxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/32888
    Petri-Dish: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  7950811   CMake: fix Windows build when all binaries are disabled
     add  cf5b867   Adding the missing generic method to support multiple vendor-defined ext types


Summary of changes:
 epan/dissectors/packet-eap.c | 31 +++++++++++++++++++++++--------
 epan/dissectors/packet-wps.c | 27 +++++++++++++++++++--------
 epan/dissectors/packet-wps.h |  9 +++++----
 3 files changed, 47 insertions(+), 20 deletions(-)