Wireshark-commits: [Wireshark-commits] master 1998de8: wsutil: Warn on empty arguments
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 18 Apr 2019 06:00:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1998de886cbeb5aceef017fe4c2d03e754a90bb9
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1998de8 by Tomasz Moń (desowin@xxxxxxxxx):

    wsutil: Warn on empty arguments
    
    Callers should not include empty strings in arguments list. Log warning
    message instead of silently dropping remaining arguments.
    
    Change-Id: Ia68c7b90cec860e032f81a4008aa005b07ebcfd5
    Ping-Bug: 15586
    Reviewed-on: https://code.wireshark.org/review/32849
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c464186   Only do the read loop in the TRY block.
     add  1998de8   wsutil: Warn on empty arguments


Summary of changes:
 wsutil/ws_pipe.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)