Wireshark-commits: [Wireshark-commits] master 6033e51: CIP: Don't parse error responses as Success
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 17 Apr 2019 04:35:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6033e51733421c71cfbc6af89ffe594bbdcbe184
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6033e51 by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP: Don't parse error responses as Success
    
    Remove most cases where we were processing CI_GRC_SERVICE_ERROR as a
    success condition.
    Leave CI_GRC_SERVICE_ERROR in some cases where this may make sense, eg:
    Modbus embedded messages may still want to be parsed as the embedded
    format.
    
    Bug: 15669
    Change-Id: I44cae1ea8d3bacd6291a3118750f8a9e825de044
    Reviewed-on: https://code.wireshark.org/review/32874
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  7a89e6a   CIP Security: Fix some off by 1
     add  6033e51   CIP: Don't parse error responses as Success


Summary of changes:
 epan/dissectors/packet-cip.c       | 4 ++--
 epan/dissectors/packet-cipsafety.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)