Wireshark · Wireshark-commits: [Wireshark-commits] master 458fa7b: Qt: Display checkboxes for extcap multicheck

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=458fa7b27412db389dba376a26c5e8b3184b1814
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

458fa7b by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Display checkboxes for extcap multicheck
    
    Multicheck was introduced to make it easy to configure USBPcap to
    capture only from selected devices instead of the whole Root Hub.
    In GTK+ interface the multicheck enabled options featured a checkbox
    next to the item entry. Displaying the checkboxes made it intuitive to
    the user that the items can be checked/unchecked.
    
    During the GTK+ to Qt transition, the checkbox idea got lost. The GTK+
    interface up to its very last days did show the checkboxes.
    While it is possible to select the individual devices in Qt UI and
    actually have USBPcap to capture only on selected devices, it is really
    unintuitive and the user simply has to know how the multicheck is
    implemented to take advantage of it.
    
    This change brings the multicheck checkboxes to Qt UI.
    
    Ping-Bug: 13355
    Change-Id: Ia677ff2222c46b9816b8dca4c47e93c72cee834f
    Reviewed-on: https://code.wireshark.org/review/32813
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  65b5f50   modbustcp: fix a shadowed variable warning
     add  458fa7b   Qt: Display checkboxes for extcap multicheck


Summary of changes:
 ui/qt/extcap_argument_multiselect.cpp | 38 +++++++++++++++++------------------
 ui/qt/extcap_argument_multiselect.h   |  4 ++--
 2 files changed, 21 insertions(+), 21 deletions(-)