Wireshark-commits: [Wireshark-commits] master c442ee0: extcap_parser: remove G_REGEX_RAW from line
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 12 Apr 2019 09:23:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c442ee056bc46bcda59e473c00d5741ea90a1453
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c442ee0 by Dario Lombardo (lomato@xxxxxxxxx):

    extcap_parser: remove G_REGEX_RAW from line parsing.
    
    Check for utf8 valid line instead. Add a testcase that shows
    how the former code was buggy on special characters extcap sentences.
    
    Bug: 15668
    Change-Id: Ic045c4791388af98705916e6ea84be8fc9b3c5b8
    Reviewed-on: https://code.wireshark.org/review/32754
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  c1dcf8c   BER: put the space to the left side of the bracket
     add  c442ee0   extcap_parser: remove G_REGEX_RAW from line parsing.


Summary of changes:
 extcap_parser.c      | 11 ++++++++---
 test/sampleif.py     | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 test/suite_clopts.py | 26 +++++++++++++++++++++++++
 3 files changed, 88 insertions(+), 3 deletions(-)
 create mode 100755 test/sampleif.py