Wireshark-commits: [Wireshark-commits] master 8b6eb05: ieee80211: One to one mapping between conver
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Apr 2019 02:21:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b6eb05bb3ae7b27267a48d7cb248a8732bb9bc8
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8b6eb05 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    ieee80211: One to one mapping between conversations and associations
    
    In the IEEE 802.11 dissector the conversations concept is (re)used
    for tracking associations. The conversations are then used to keep
    data that's unique for a certain association, like negotiated AKMS.
    
    Though currently associations are unique per (re)association
    whereas conversations are unique based only on src/dest address.
    This is problematic for captures with multiple associations with
    same STA/BSSI pair.
    
    For example:
    Assoc req frame (assoc #1, conversation #1)
    Reassoc frame (assoc #2, conversation #1)
    Assoc req frame (assoc #3, conversation #1)
    
    To make a one to one mapping between conversations and associations
    store an association counter with each frame and use it with the pinfo
    srcport/destport fields to build a conversation key:
    (src, dest, association_counter).
    
    Bug: 15616
    Change-Id: Ie020bdffbcdab4739ee07f73025ef1157c1fc329
    Reviewed-on: https://code.wireshark.org/review/32737
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  47361b2   ieee80211: Handle variable MIC length for FT IE
     add  8b6eb05   ieee80211: One to one mapping between conversations and associations


Summary of changes:
 epan/dissectors/packet-ieee80211.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)