Wireshark-commits: [Wireshark-commits] master 4c8a226: Explicitly make cf->{rec, buf} the informati
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 06 Apr 2019 23:22:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4c8a226c075732f83e77757ccaff31f32d92f9e8
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4c8a226 by Guy Harris (guy@xxxxxxxxxxxx):

    Explicitly make cf->{rec,buf} the information for the selected packet.
    
    Move it next to other capture_file fields for the currently-selected
    packet, add a comment indicating that's what all those fields are for,
    separate them from the following fields that *aren't* for the
    currently-selected field, and explicitly use them in cf_select_packet().
    
    Also add a comment about why we're waiting until the end to free up the
    old cf->edt in cf_select_packet() and cf_unselect_packet().
    
    Change-Id: I1653af06eeb4ebe1131bc08bcaa2dc639932c7fa
    Ping-Bug: 15683
    Reviewed-on: https://code.wireshark.org/review/32764
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6636fa3   NR RRC: upgrade dissector to v15.5.0
     add  4c8a226   Explicitly make cf->{rec,buf} the information for the selected packet.


Summary of changes:
 cfile.h | 15 ++++++++-------
 file.c  | 26 ++++++++++++++++++++++++--
 2 files changed, 32 insertions(+), 9 deletions(-)