Wireshark-commits: [Wireshark-commits] master 937ec02: 1514 is a better initial Buffer size than 15
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 06 Apr 2019 21:04:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=937ec02581ee3918e6caa6de75340c28593a22d5
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

937ec02 by Guy Harris (guy@xxxxxxxxxxxx):

    1514 is a better initial Buffer size than 1500.
    
    Ethernet packets without the CRC are 1514 bytes long, not 1500 bytes
    long; using 1514 bytes will avoid a reallocation for a full-sized
    Ethernet packet.
    
    Change-Id: Ie8da3f13bf3df07e23e4478b7dcf84f06dec6a9d
    Reviewed-on: https://code.wireshark.org/review/32761
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f0a2b83   Revert "Get rid of the per-capture_file wtap_rec and Buffer."
     add  937ec02   1514 is a better initial Buffer size than 1500.


Summary of changes:
 capinfos.c                          |  2 +-
 capture_info.c                      |  2 +-
 editcap.c                           |  2 +-
 file.c                              | 14 +++++++-------
 rawshark.c                          |  2 +-
 reordercap.c                        |  4 ++--
 sharkd.c                            | 10 +++++-----
 tfshark.c                           |  2 +-
 tshark.c                            |  8 ++++----
 ui/file_dialog.c                    |  2 +-
 ui/proto_hier_stats.c               |  2 +-
 ui/qt/models/packet_list_record.cpp |  2 +-
 ui/qt/packet_list.cpp               |  2 +-
 ui/qt/utils/frame_information.cpp   |  2 +-
 wiretap/merge.c                     |  2 +-
 15 files changed, 29 insertions(+), 29 deletions(-)