Wireshark-commits: [Wireshark-commits] master 5bd6d44: Dissect USB "device" Setup CONTROL messages
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 06 Apr 2019 07:24:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5bd6d44ba6624f7a65819e759b13b6d25875e720
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5bd6d44 by Artem Mygaiev (joculator@xxxxxxxxx):

    Dissect USB "device" Setup CONTROL messages
    
    Before this change Wireshark would assume there is no USB devices that
    use "device" recepient (RQT_SETUP_RECIPIENT_DEVICE) in Setup stage of
    USB CONTROL messages. But there are plenty of such, examples are:
    FrescoLogic's FL2000 USB Display controller, Razer USB peripherals;
    there are open projects that investigate protocols for them in order to
    implement OSS drivers and SW stacks.
    
    Allow dissection of USB "device" Setup CONTROL messages by treating them
    in the same way as "other" or "reserved" with assumption that at least
    IntefaceClass is set to UNKNWON (0xffff) which is true for at least
    beforementioned FL2000 and Razer HW implementations.
    
    Change-Id: I44f4f8cdccd973194aeda2c39c59529d531c31b2
    Reviewed-on: https://code.wireshark.org/review/32626
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  98bcda5   Make call_dissector assertions non-fatal.
     add  5bd6d44   Dissect USB "device" Setup CONTROL messages


Summary of changes:
 epan/dissectors/packet-usb.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)