Wireshark-commits: [Wireshark-commits] master-3.0 2f529f8: dcerpc: ensure the length in the packet
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 05 Apr 2019 22:23:40 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f529f8acf96a423a27bf52c70ebd6b837a346c4
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

2f529f8 by Dario Lombardo (lomato@xxxxxxxxx):

    dcerpc: ensure the length in the packet doesn't overcome the boundaries.
    
    The spoolss dissector creates a new source using the length from the packet
    data. If it overcomes the ends of the packet we hit a crash. In this case
    add an expert info and stop the dissection
    
    Bug: 15568
    Change-Id: Idfb0b54c1f41842170d3d03c80897a3b7edc9400
    Reviewed-on: https://code.wireshark.org/review/32449
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 5aba3ed0cdebc1ec960261e3e9eda87c8408259f)
    Reviewed-on: https://code.wireshark.org/review/32748
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  1c23707   Gen-bugnote: Replace multiple instances where needed.
     add  2f529f8   dcerpc: ensure the length in the packet doesn't overcome the boundaries.


Summary of changes:
 epan/dissectors/packet-dcerpc-spoolss.c | 9 +++++++++
 1 file changed, 9 insertions(+)