Wireshark-commits: [Wireshark-commits] master-2.4 441b6d9: DOF: Fix alias binding dissection.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 04 Apr 2019 23:34:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=441b6d9071d6341e58dfe10719375489c5b8e3f0
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

441b6d9 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    DOF: Fix alias binding dissection.
    
    When adding generated IID and OID bytes to the tree, use a zero offset
    and length like we do elsewhere in the dissector.
    
    Bug: 15617
    Change-Id: Id900f2aeeef7926706b417622d452ffa72949e8a
    (cherry picked from commit ecf03bb37b3345e684890f7eee031cb17a247939)
    Reviewed-on: https://code.wireshark.org/review/32723
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 651cd91b16b01e3da698b04542da376d946bc54b)
    Reviewed-on: https://code.wireshark.org/review/32725
    

Actions performed:

    from  b16fea2   srvloc: check buffer index to prevent heap overflow.
     add  441b6d9   DOF: Fix alias binding dissection.


Summary of changes:
 epan/dissectors/packet-dof.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)