Wireshark-commits: [Wireshark-commits] master 6764435: Clean file reading code.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 04 Apr 2019 10:21:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67644354a13051bff3d93c5235902e29234aceee
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6764435 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean file reading code.
    
    Put the pass 1 of a two-pass read, pass 2 of a two-pass read, and only
    pass of a one-pass read into separate routines, returning success/read
    error/write error status codes.
    
    This makes the processing a bit cleaner, and makes it easier to have the
    file-reading code catch signals/control events.
    
    Change-Id: I58cd9e4b86f219f3afa2dc61b57f41978fc2f853
    Reviewed-on: https://code.wireshark.org/review/32711
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5232409   ieee80211: FT over IEEE 802.1X (SHA384) is an FT AKMS
     add  6764435   Clean file reading code.


Summary of changes:
 tshark.c | 625 ++++++++++++++++++++++++++++++++++++---------------------------
 1 file changed, 359 insertions(+), 266 deletions(-)