Wireshark-commits: [Wireshark-commits] master-3.0 be66fa4: FP: Fix ToA shown as unsigned
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 03 Apr 2019 17:59:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be66fa4bc877d038f3b2056f6179c56287543068
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

be66fa4 by Darien Spencer (cusneud@xxxxxxxx):

    FP: Fix ToA shown as unsigned
    
    The 'sign' bit was treated like a regular bit because of direct casting to a wider int type
    
    Change-Id: Id0f095fa9bda97ecbdfc32f3610271eeea86fc2e
    Reviewed-on: https://code.wireshark.org/review/32688
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 13f8f2c8dd97c1ab98e66b6716ed4b993fbfe78d)
    Reviewed-on: https://code.wireshark.org/review/32699
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1cf349d   ldss: add checks on file digest.
     add  be66fa4   FP: Fix ToA shown as unsigned


Summary of changes:
 epan/dissectors/packet-umts_fp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)