Wireshark-commits: [Wireshark-commits] master 4b81418: ieee80211: Fix WPA1 decryption
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 03 Apr 2019 15:26:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4b814187acf36b74479f6bd61d3ca98ff5d5734c
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4b81418 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    ieee80211: Fix WPA1 decryption
    
    PTK key derivation algorithm for WPA1 uses SHA1 not MD5.
    MD5 is used for MIC only.
    
    To avoid regression also add a decrypt test for WPA1 with
    GTK rekeying.
    
    Change-Id: Iabcf40c2f74d5dbc1d72cba0718c77020d97f61f
    Fixes: v3.1.0rc0-342-g9cf77ec5e1 ("ieee80211: Support decrypting WPA3-Personal / SAE captures")
    Reviewed-on: https://code.wireshark.org/review/32691
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  6c34679   ldss: add checks on file digest.
     add  4b81418   ieee80211: Fix WPA1 decryption


Summary of changes:
 epan/crypt/dot11decrypt.c              |   4 ++--
 test/captures/wpa1-gtk-rekey.pcapng.gz | Bin 0 -> 7114 bytes
 test/suite_decryption.py               |  11 +++++++++++
 3 files changed, 13 insertions(+), 2 deletions(-)
 create mode 100644 test/captures/wpa1-gtk-rekey.pcapng.gz