Wireshark-commits: [Wireshark-commits] master-2.6 3319938: HL7: do not call proto_reg_handoff_hl7()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 01 Apr 2019 08:52:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3319938940f1af5175553cb7200a66114751c9a3
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

3319938 by Pascal Quantin (pascal@xxxxxxxxxxxxx):

    HL7: do not call proto_reg_handoff_hl7() when changing a preference
    
    None of the preference require this function to be called again and it
    it not designed to be called several times (systematically adds the
    dissector handle).
    
    Change-Id: I0aca361902e65668c991e26025236c7ebb0fe946
    Reviewed-on: https://code.wireshark.org/review/32666
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 2f09f6aba4c6bc31fc3330d3e25e54c6fdef8309)
    Reviewed-on: https://code.wireshark.org/review/32670
    

Actions performed:

    from  ee52f41   On Windows, don't do console stuff unless we're on a terminal.
     add  3319938   HL7: do not call proto_reg_handoff_hl7() when changing a preference


Summary of changes:
 epan/dissectors/packet-hl7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)