Wireshark-commits: [Wireshark-commits] master ed23cfb: Clean up IPMB/I2C link-layer header types.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 23 Mar 2019 20:30:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ed23cfba226b6e21f3e97147f19e617bddc0c5e9
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ed23cfb by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up IPMB/I2C link-layer header types.
    
    209 is LINKTYPE_IPMB_LINUX; add _LINUX/_linux to the WTAP_ENCAP_ name
    and function/structure names, to clarify that it's not I2C in general,
    it's I2C with a particular pseudo-header.
    
    199 is now LINKTYPE_IPMB_KONTRON, not LINKTYPE_IPMB, as it doesn't have
    raw I2C packets, it has I2C packets with a pseudo-header.  Change the
    WTAP_ENCAP_ name, and add a dissector for it.
    
    Change-Id: Ie097f4317b03d2b2adfd9b81a4b11caf6268399e
    Reviewed-on: https://code.wireshark.org/review/32539
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  80d96e9   Restore pinfo->match_uint after the topmost dissector returns.
     add  ed23cfb   Clean up IPMB/I2C link-layer header types.


Summary of changes:
 epan/dissectors/packet-i2c.c          | 72 +++++++++++++++++++++++++++++------
 epan/dissectors/packet-pcap_pktdata.c |  2 +-
 test/lua/globals_2.2.txt              |  4 +-
 wiretap/pcap-common.c                 | 59 ++++++++++++++--------------
 wiretap/wtap.c                        |  8 ++--
 wiretap/wtap.h                        |  4 +-
 6 files changed, 100 insertions(+), 49 deletions(-)