Wireshark-commits: [Wireshark-commits] master-3.0 7b56309: print: don't ignore FT_NONE fields in ek
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 23 Mar 2019 00:05:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b56309bf4ea4b2e26a67e675cef62e040c8c02a
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

7b56309 by Dario Lombardo (lomato@xxxxxxxxx):

    print: don't ignore FT_NONE fields in ek.
    
    The 'null' placeholder has been used in such a fields. Otherwise
    the json dumper would complain for the lack of a value, getting
    confused by a double name add without values.
    
    Bug: 15628
    Change-Id: I016325790f8d4a02ed9288225e861ba2d23a82f9
    Reviewed-on: https://code.wireshark.org/review/32532
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit c4dc670e24c86d14852ec735bb1201c9f5986f87)
    Reviewed-on: https://code.wireshark.org/review/32538
    

Actions performed:

    from  23803a0   TLS: fix potential buffer overflow with a malicious SSL 3.0 session
     add  7b56309   print: don't ignore FT_NONE fields in ek.


Summary of changes:
 epan/print.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)