Wireshark-commits: [Wireshark-commits] master-3.0 19bdf73: Fix order of ring buffer and auto-stop i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 22 Mar 2019 13:02:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=19bdf734f753713241adeccf7de0934a2d0c5032
Submitter: "Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

19bdf73 by Jeff Morriss (jeff.morriss@xxxxxxxxxxxx):

    Fix order of ring buffer and auto-stop items on the Capture Options page.
    
    Apparently the order of the items defined here affects the order in which
    order tab will cycle through them.  See:
    
    https://ask.wireshark.org/question/8010/wireshark-ring-buffer-settings-page-tab-sequence/
    
    Sort the items by row and then by column; this gives a natural order when
    tabbing through.
    
    Change-Id: I1137ef59a3fbf506734d828d9bdfa87bddb96c3b
    Reviewed-on: https://code.wireshark.org/review/32500
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  868ceb7   randpkt: restore produce_filename in random generation.
     add  19bdf73   Fix order of ring buffer and auto-stop items on the Capture Options page.


Summary of changes:
 ui/qt/capture_interfaces_dialog.ui | 296 ++++++++++++++++++-------------------
 1 file changed, 148 insertions(+), 148 deletions(-)