Wireshark-commits: [Wireshark-commits] master f2e511e: No need for a per-instance private sctp_alla
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Mar 2019 22:04:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f2e511e14824cd66d67530ad37a0a8b250038f06
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f2e511e by Guy Harris (guy@xxxxxxxxxxxx):

    No need for a per-instance private sctp_allassocs_info_t pointer.
    
    The result of sctp_stat_get_info() is only used in fillTable, so there's
    no need to save it.
    
    Make it a const pointer, to squelch warnings.
    
    Change-Id: Icb6fd7e2f5c3c5c53f7d33509d100a0947e69369
    Reviewed-on: https://code.wireshark.org/review/32460
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  86c9d41   Don't remove constness in a cast if it's not necessary.
     add  f2e511e   No need for a per-instance private sctp_allassocs_info_t pointer.


Summary of changes:
 ui/qt/sctp_all_assocs_dialog.cpp | 3 ++-
 ui/qt/sctp_all_assocs_dialog.h   | 1 -
 2 files changed, 2 insertions(+), 2 deletions(-)