Wireshark-commits: [Wireshark-commits] master 14796eb: Windows: Console log handler fixups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 Mar 2019 21:15:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14796eb04a853a8ad772011b29c029a26ae15418
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

14796eb by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Windows: Console log handler fixups.
    
    Make sure that we always print log messages on Windows. External programs
    or scripts (including our test suite) might need to see log messages
    independent of our console settings.
    
    Make sure that we always use our log handler and that its stdout /
    stderr routing matches GLib's. Flush our log output, which is something
    that GLib's default handler sometimes doesn't do:
    https://bugzilla.gnome.org/show_bug.cgi?id=792432
    
    Bug: 15605
    Change-Id: I4b17f2cb9269b2c87c21835d82770dae93bbfa20
    Reviewed-on: https://code.wireshark.org/review/32412
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  3b2204e   wmem: fix a comment.
     add  14796eb   Windows: Console log handler fixups.


Summary of changes:
 ui/console.c             | 113 ++++++++++++++++++----------------------
 ui/win32/console_win32.c | 130 ++++++++++++++++++++++-------------------------
 ui/win32/console_win32.h |   7 ---
 3 files changed, 110 insertions(+), 140 deletions(-)