Wireshark-commits: [Wireshark-commits] master fd7ff69: Ask in a comment whether we should test HAVE
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 10 Mar 2019 18:12:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd7ff6916ca06b6a501a9c1675020d409718aef7
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

fd7ff69 by Guy Harris (guy@xxxxxxxxxxxx):

    Ask in a comment whether we should test HAVE_STRUCT_STAT_ST_BLKSIZE.
    
    We're defining it now based on whether there's an st_blksize member of
    struct stat.  We're currently testing _STATBUF_ST_BLKSIZE, but that's
    not guaranteed to be defined on platforms that have an st_blksize member
    of struct stat (it's not defined on macOS, for example).
    
    Change-Id: I4e6011a7668da94cf1ca6328e29c50924dd1d8b0
    Reviewed-on: https://code.wireshark.org/review/32381
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e901d72   GSM A RR: fix Frequency List Variable Bitmap IE dissection
     add  fd7ff69   Ask in a comment whether we should test HAVE_STRUCT_STAT_ST_BLKSIZE.


Summary of changes:
 wiretap/file_wrappers.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)