Wireshark-commits: [Wireshark-commits] master 4273d0b: Allow %D and %T in date/time formats.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 09 Mar 2019 23:30:27 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4273d0b170033848df7ad0cfe9934320390af85e
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4273d0b by Guy Harris (guy@xxxxxxxxxxxx):

    Allow %D and %T in date/time formats.
    
    1) They're both required, for both strftime() and strptime(), by the
    Single UNIX Specification.
    
    2) They're both supported by MSVC's strftime(), at least as of VS 2015.
    
    3) With MSVC, we use our own strptime(), which is based on the GNU libc
    one and which supports both of them.
    
    So we don't have to worry about them not working and either giving a
    bogus value or throwing an exception or anything such as that.
    
    Bug: 15565
    Change-Id: I72b7798f35c4461855298cfcfa84732c1297d5fe
    Reviewed-on: https://code.wireshark.org/review/32370
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e451ea0   Qt: fix compilation with old compilers.
     add  4273d0b   Allow %D and %T in date/time formats.


Summary of changes:
 ui/qt/import_text_dialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)