Wireshark-commits: [Wireshark-commits] master e2143e9: nl80211: Fix HT/VHT capability attribute par
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 09 Mar 2019 08:53:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2143e93ebfe598bac174bd1fb2e2ef82f462bd6
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e2143e9 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    nl80211: Fix HT/VHT capability attribute parsing
    
    The NL80211_ATTR_HT_CAPABILITY and NL80211_ATTR_VHT_CAPABILITY
    attributes does not contain the full information element tlv
    making the dissector fail to parse the attribute values.
    
    Add a tag dissector function that dissects a numbered tag using
    the 802.11 tag dissector table and use it to dissect HT/VHT
    capability attributes properly.
    
    The HE capabily tag is among the extended tags so must be handled
    in some other way. For now leave the attribute undissected.
    
    Change-Id: Ie85918634bafc2b39000a34b01e7a7dbaf6bd80d
    Reviewed-on: https://code.wireshark.org/review/32365
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  dfb98b8   nl80211: Parse FRAME attribute using 802.11 dissector
     add  e2143e9   nl80211: Fix HT/VHT capability attribute parsing


Summary of changes:
 epan/dissectors/packet-netlink-nl80211.c | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)