Wireshark-commits: [Wireshark-commits] master b080033: Remove the periodic interface update in wire
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b08003309b9387f4c839b6c4516da602349af177
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
b080033 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):
Remove the periodic interface update in wireless toolbar
The wireless toolbar retrieves the full list of network interfaces
every 1.5 seconds to keep its list of interfaces updated. This
not only adds unnecessary load on the system it also generates
plenty of netlink traffic. When capturing packets on nlmon
interfaces they are flooded with packets generated by Wireshark
itself making it hard to understand the traffic that's really present
on the system.
Remove the periodic interface update and instead listen to network
interface change events and update only when something has changed.
The wireless toolbar need to know all when wireless interfaces are
added/removed, not only whether an interface is 'up' or not so
iface_monitor changes were also necessary.
Bug: 15576
Change-Id: I8fb19fd919dfef1b6b35bf48790b105ecd2b60a8
Reviewed-on: https://code.wireshark.org/review/32350
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 28c5b73 Updates and bugfixes of ASTERIX
add b080033 Remove the periodic interface update in wireless toolbar
Summary of changes:
caputils/iface_monitor.c | 18 ++++++++++---
caputils/iface_monitor.h | 2 +-
ui/qt/wireless_frame.cpp | 56 +++++++++++++++++++++++++++++++++--------
ui/qt/wireless_frame.h | 7 +++++-
ui/qt/wireshark_application.cpp | 8 +++++-
ui/qt/wireshark_application.h | 2 ++
6 files changed, 75 insertions(+), 18 deletions(-)
