Wireshark · Wireshark-commits: [Wireshark-commits] master-3.0 0c614f0: Clean up ITU-T vs. CCITT, fix some comments.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0c614f0e1bea769ab3da314fabe2908888b2e263
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

0c614f0 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up ITU-T vs. CCITT, fix some comments.
    
    The CCITT was part of the ITU, and was renamed the ITU-T:
    
    	https://en.wikipedia.org/wiki/ITU-T#History
    
    so just say ITU-T.  As for whose idea those particular 16-bit and 32-bit
    CRC generator polynomials originally were, I don't know. 802.15.4 speaks
    of "a 32-bit CRC equivalent to ANSI X3.66-1979", but there ain't no
    32-bit CRC in that standard, and its 16-bit CRC is Yet Another
    x^16 + x^12 + x^5 + 1 CRC that they claim came from CCITT/ITU-T V.41;
    V.42 has both 16-bit and 32-bit CRCs.
    
    Clean up more comments about the TI CC24xx metadata trailer.
    
    The "non-ASK PHY" name may have made sense when the type was created, as
    all the PHYs other than ASK, at the time, may have had the same
    preamble/SFD/PHR, but that's no longer true.  List, in a comment, the
    ones to which it applies, all of which have 16-bit CRCs.
    
    Change-Id: Ie509dc06d06aec9738447f8da254c4edc5971a92
    Reviewed-on: https://code.wireshark.org/review/32276
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 65ca4b4da7268a0849e3f353d3141fe9b8e59a7e)
    Reviewed-on: https://code.wireshark.org/review/32323
    

Actions performed:

    from  d55127c   Replace another tvb_new_subset_length_caplen() call.
     add  0c614f0   Clean up ITU-T vs. CCITT, fix some comments.


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 52 +++++++++++++++++++++++++++----------
 1 file changed, 38 insertions(+), 14 deletions(-)