Wireshark · Wireshark-commits: [Wireshark-commits] master-3.0 bfe4e1b: Remove FCS length checks from code that's handed a tvbuff wi

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bfe4e1bdd7b15344f16c062f3daaa754443908f5
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

bfe4e1b by Guy Harris (guy@xxxxxxxxxxxx):

    Remove FCS length checks from code that's handed a tvbuff without an FCS.
    
    Data handed to dissect_ieee802154_decrypt() should have, and does, have
    the FCS stripped off, so we don't need to use the FCS length.
    
    While we're at it:
    
    Update more comments for CC24xx metadata not being an FCS.
    
    Do the header IE processing loop with a "data remaining" counter,
    explain why we're doing a "data remaining" check and why it includes the
    MIC length, and note that we should use the "data remaining" counter to
    do more checks for invalid frames.
    
    Change-Id: I928dbf6142b5876b6a25b954f798936c9e97ac0d
    Reviewed-on: https://code.wireshark.org/review/32267
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit c6781b6385075ef0d289529b6ec165ec2f22aed2)
    Reviewed-on: https://code.wireshark.org/review/32320
    

Actions performed:

    from  b4c35c3   maxmind_db: Work around an apparent GLib bug.
     add  bfe4e1b   Remove FCS length checks from code that's handed a tvbuff without an FCS.


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 69 ++++++++++++++++++++++++++-----------
 1 file changed, 48 insertions(+), 21 deletions(-)