Wireshark-commits: [Wireshark-commits] master-2.6 970e383: Discard the upper bits of the "network"
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 Mar 2019 23:47:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=970e383702349954070276ad490bb36343d64fb5
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

970e383 by Guy Harris (guy@xxxxxxxxxxxx):

    Discard the upper bits of the "network" field in the file header.
    
    Libpcap's done that for a while; we should do so as well.
    
    (Ideally, we should use those bits, but there's an issue with pcapng,
    where the FCS length in the IDB is described as being in units of bits,
    but where we're treating it as being in units of bytes, that I'd like to
    resolve first.)
    
    Change-Id: Ibcb82f1dcaa8baae5bba55636cea8852a6af814e
    Reviewed-on: https://code.wireshark.org/review/32303
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit c84f69f7482fea6eb1b86f08811cc2b4547fe05f)
    Reviewed-on: https://code.wireshark.org/review/32305
    

Actions performed:

    from  98c3e3b   [Automatic update for 2019-03-03]
     add  970e383   Discard the upper bits of the "network" field in the file header.


Summary of changes:
 wiretap/libpcap.c | 45 ++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 44 insertions(+), 1 deletion(-)