Wireshark-commits: [Wireshark-commits] master f4167c3: Support unsigned stream identifiers for Foll
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 02 Mar 2019 08:29:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f4167c32e0f8d93c369b4641c4caf6d172a64c24
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f4167c3 by Peter Wu (peter@xxxxxxxxxxxxx):

    Support unsigned stream identifiers for Follow Stream
    
    tcp.stream and udp.stream are already unsigned identifiers. An upcoming
    http2.hashed_stream identifier can exercise the full unsigned 32-bit
    number space, so be sure not to treat the stream identifier as signed
    integer.
    
    Change-Id: Ic5d398b2bda7eba7555e385ef3fcd44b490f78c9
    Reviewed-on: https://code.wireshark.org/review/32287
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Alexander Gryanko <xpahos@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  712d94f   vwr: fix Uninitialized argument value found by Clang (Analyzer)
     add  f4167c3   Support unsigned stream identifiers for Follow Stream


Summary of changes:
 epan/dissectors/packet-tcp.c   | 10 +++++-----
 epan/dissectors/packet-tcp.h   |  6 +++---
 epan/dissectors/packet-udp.c   | 10 +++++-----
 epan/follow.h                  |  4 ++--
 ui/qt/conversation_dialog.cpp  |  2 +-
 ui/qt/conversation_dialog.h    |  2 +-
 ui/qt/follow_stream_dialog.cpp |  2 +-
 ui/qt/follow_stream_dialog.h   |  2 +-
 ui/qt/main_window.h            |  3 ++-
 ui/qt/main_window_slots.cpp    | 22 +++++++++++++---------
 10 files changed, 34 insertions(+), 29 deletions(-)