Wireshark-commits: [Wireshark-commits] master-3.0 014f8c1: The TI CC24xx chips put metadata, not an
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 Feb 2019 09:47:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=014f8c19255c764010a6e020a46bcefa60162a16
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

014f8c1 by Guy Harris (guy@xxxxxxxxxxxx):

    The TI CC24xx chips put metadata, not an FCS, at the end of the packet.
    
    Don't call it an "FCS" in the CC24xx case.  It's not an FCS; it's not
    even just an "FCS OK" bit.
    
    Display the metadata in question in bit order, from the "CRC OK" bit
    downwards.
    
    Change-Id: I8da29bbb1f8b5ef3905af75dd34c1563b904a4d8
    Reviewed-on: https://code.wireshark.org/review/32228
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 20b1f093fdca61a6e7f8499c6ccd5355232c581c)
    Reviewed-on: https://code.wireshark.org/review/32229
    

Actions performed:

    from  96542b3   Add support for IEEE 802.15.4 32-bit FCS
     add  014f8c1   The TI CC24xx chips put metadata, not an FCS, at the end of the packet.


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 35 ++++++++++++++++++++---------------
 epan/dissectors/packet-ieee802154.h | 14 ++++----------
 2 files changed, 24 insertions(+), 25 deletions(-)