Wireshark-commits: [Wireshark-commits] master-2.4 cab0cff: netscaler: fix crash when reading malfor
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 26 Feb 2019 19:44:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cab0cff6abdd7a5b5b0bfa4ee204eea951e129e9
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

cab0cff by Dario Lombardo (lomato@xxxxxxxxx):

    netscaler: fix crash when reading malformed packets.
    
    When reading a malformed packet, it can occur that we go close to
    the end of the buffer. We need to check if we have 2 bytes before
    reading a uint16.
    
    Bug: 15497
    Change-Id: I2b00f44933ca11b925ffbf05b9855684feebcda5
    Reviewed-on: https://code.wireshark.org/review/32028
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit efe920af3a9f4d7a35c427ceaf4f95e31050f4d3)
    Reviewed-on: https://code.wireshark.org/review/32197
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  7f3f1a1   [Automatic update for 2019-02-24]
     add  cab0cff   netscaler: fix crash when reading malformed packets.


Summary of changes:
 wiretap/netscaler.c | 6 ++++++
 1 file changed, 6 insertions(+)