Wireshark-commits: [Wireshark-commits] master c37a89b: Clean up dissection of watchdog packets.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 23 Feb 2019 21:29:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c37a89b753296ab1b104fbbd0c73d464e931dd78
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c37a89b by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up dissection of watchdog packets.
    
    Novell's documentation calls the code a "Signature Character"; do so.
    
    It's a character, so make it an FT_CHAR, now that we have FT_CHAR, so
    it's displayed as 'Y' or '?' for normal packets.
    
    Change-Id: If600f559fe05b80a915bbc51ceb34783bdc397db
    Reviewed-on: https://code.wireshark.org/review/32176
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5b9bbaf   Fix dissection of Large Internet Packet echos.
     add  c37a89b   Clean up dissection of watchdog packets.


Summary of changes:
 epan/dissectors/packet-ncp.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)