Wireshark-commits: [Wireshark-commits] master-3.0 8ef4d41: Fix liblzma, liblz4, and libssh builds w
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 23 Feb 2019 19:22:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ef4d41b47d5e8a95b17cdc66faf67f7cc4d0e3a
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

8ef4d41 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix liblzma, liblz4, and libssh builds with minimum deployment version and SDK.
    
    liblzma is used by libxml2, which is used by libwireshark, so we need
    it.  It's build by xz, so we need to do the xz build with the
    minimum-version and SDK flags.
    
    liblz4 does its builds in its own unique way; it appears we need to set
    MOREFLAGS to include the relevant flas.
    
    libssh is built with CMake, so you have to do special magic to set the
    SDK path; do it by running cmake with the MACOSX_DEPLOYMENT_TARGET and
    SDKROOT environment variables.
    
    Change-Id: Ia588632e5047c4a8a22fe6ef3a0844cfe7722df2
    Reviewed-on: https://code.wireshark.org/review/32171
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 86f295b835ce27045f9671f1a0d5c332a46d5822)
    Reviewed-on: https://code.wireshark.org/review/32172
    

Actions performed:

    from  f5d3e0c   pcap: Update link_type_vals
     add  8ef4d41   Fix liblzma, liblz4, and libssh builds with minimum deployment version and SDK.


Summary of changes:
 tools/macos-setup.sh | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)