Wireshark-commits: [Wireshark-commits] master-3.0 24353b8: Qt: Fix removal of "Capture to a permane
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 20 Feb 2019 07:07:22 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=24353b82cd0fbd76e3156fca4eaf52c7d2a3e81c
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

24353b8 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Fix removal of "Capture to a permanent file" setting
    
    Make it possible to remove the "Capture to a permanent file" setting
    in Capture Interfaces Output dialog by turning off saving_to_file in
    updateInterfaces().
    
    Also make sure to free the old values for save_file and orig_save_file
    to avoid memory leaks.
    
    Set orig_save_file to the same as save_file from the '-w' option to
    fill in the current "Capture to a permanent file" value correctly.
    
    Change-Id: I1f4df8cfa279f934eff028f32838b9734b627af1
    Reviewed-on: https://code.wireshark.org/review/32111
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 1df39d65f567803929f4b009409f872cd7c46622)
    Reviewed-on: https://code.wireshark.org/review/32118
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  682b75c   Qt: Fix restart capture when using a ring buffer
     add  24353b8   Qt: Fix removal of "Capture to a permanent file" setting


Summary of changes:
 capture_opts.c                      | 1 +
 ui/qt/capture_interfaces_dialog.cpp | 5 +++++
 2 files changed, 6 insertions(+)