Wireshark · Wireshark-commits: [Wireshark-commits] master 24e71ae: Modbus: If response packet is not found, base registers/coils on

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=24e71ae4f53614a1964c76316e316176ef6c67ec
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

24e71ae by Michael Mann (mmann78@xxxxxxxxxxxx):

    Modbus: If response packet is not found, base registers/coils on byte count.
    
    Previously Modbus dissector was using request data to determine how many coils
    or registers to dissect.  However, if the request wasn't found, it wouldn't dissect
    all of the coil/request data.  Now if pkt_info->num_reg is 0, use the byte count in
    the packet for determining how many registers/coils there are.
    
    Bug: 15473
    Change-Id: I8818ba53187248fea4ccc2b5077985ab94578886
    Reviewed-on: https://code.wireshark.org/review/32077
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4b66843   NAS 5Gs: Ignoring MM capability spare octets
     add  24e71ae   Modbus: If response packet is not found, base registers/coils on byte count.


Summary of changes:
 epan/dissectors/packet-mbtcp.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)