Wireshark-commits: [Wireshark-commits] master-3.0 16abb3b: Re-implement "Map" feature for Endpoints
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 Feb 2019 21:53:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=16abb3bfbd294fe9460c562b1bfff1e71883b511
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

16abb3b by Peter Wu (peter@xxxxxxxxxxxxx):

    Re-implement "Map" feature for Endpoints
    
    This feature was removed in v2.5.1rc0-427-gf529ab5d0a, anticipating that
    MaxMind would remove support for it in 2019. They have however changed
    their mind and maintained latitude and longitude information.
    
    They recommend displaying an accuracy radius, but the reported values
    are 50, 100, 200 and 1000km. When implemented literally, a marker in
    Ireland would cover the whole island plus mainland, so I have instead
    opted to use a fixed radius of 1km at deeper zoom levels.
    
    The old ipmap.html file was outdated and had broken tiles, I rewrote a
    new one from scratch using the light-weight Leaflet library combined
    with tiles from OpenStreetMap. This is more mobile-friendly and secure
    (https, SRI). To improve handling of nearby or overlapping nodes,
    clustering is used (individual nodes can still be inspected).
    
    Browser compatibility results: IE8 is unusable, IE9 partially works
    (tooltips sometimes disappear and the cluster radius control is gone),
    IE11 works. Of course Firefox 65 and Chromium 72 have no issues.
    
    The map popup description in the generated GeoJSON structure is now
    split in several properties, allowing presentation to be handled by the
    HTML page instead of the C code.
    
    Bug: 14693
    Change-Id: If2ec9c518f7723ac0ab27b6272463356875a0ff2
    Reviewed-on: https://code.wireshark.org/review/31952
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit ba1ef0ec3d15927e72d3705bed295807e5054a75)
     [Peter: added release-notes entry]
    Reviewed-on: https://code.wireshark.org/review/32060
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  f6037a1   Don't allow NSIS or WiX installers if we aren't building Wireshark.
     add  16abb3b   Re-implement "Map" feature for Endpoints


Summary of changes:
 CMakeLists.txt                                    |   1 +
 docbook/release-notes.asciidoc                    |   3 +-
 docbook/wsug_src/WSUG_chapter_statistics.asciidoc |   3 +-
 epan/maxmind_db.c                                 |   9 +-
 epan/maxmind_db.h                                 |  10 +
 ipmap.html                                        | 380 ++++++++++++++++++++++
 mmdbresolve.c                                     |   4 +-
 packaging/nsis/uninstall.nsi                      |   1 +
 packaging/nsis/wireshark.nsi                      |   1 +
 packaging/wix/ComponentGroups.wxi                 |   3 +
 ui/qt/endpoint_dialog.cpp                         | 162 ++++++++-
 ui/qt/endpoint_dialog.h                           |  21 ++
 ui/traffic_table_ui.c                             | 176 +++++++++-
 ui/traffic_table_ui.h                             |  38 ++-
 14 files changed, 787 insertions(+), 25 deletions(-)
 create mode 100644 ipmap.html