Wireshark-commits: [Wireshark-commits] master-2.6 d107755: Don't bother with BUILD_wireshark_gtk vs
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 15 Feb 2019 05:01:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d107755099ac574a1c185a94a135b5f94833da25
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

d107755 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't bother with BUILD_wireshark_gtk vs. not BUILD_wireshark_gtk.
    
    FindGLIB2.cmake doesn't, so don't bother in FindGMODULE2.cmake or
    FindGTHREAD2.cmake.
    
    FindGLIB2.cmake also does the FindWSWinLibs() even when not on Windows,
    so go back to working that way in FindGMODULE2.cmake FindGTHREAD2.cmake.
    The "finding stuff" code needs more cleanup.
    
    Change-Id: I252235d4ea183491ac7a889954964098ad331cfc
    Reviewed-on: https://code.wireshark.org/review/32042
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  70d389f   Clean up searches for GLib submodules on Windows.
     add  d107755   Don't bother with BUILD_wireshark_gtk vs. not BUILD_wireshark_gtk.


Summary of changes:
 cmake/modules/FindGMODULE2.cmake | 31 +++++++------------------------
 cmake/modules/FindGTHREAD2.cmake | 31 +++++++------------------------
 2 files changed, 14 insertions(+), 48 deletions(-)