Wireshark-commits: [Wireshark-commits] master-3.0 518d267: frame: fix crash when dissectors add the
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 Feb 2019 13:32:22 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=518d267258a19a2c9760dd08c9b7923707ba93a5
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

518d267 by Dario Lombardo (lomato@xxxxxxxxx):

    frame: fix crash when dissectors add the maximum number of tree items.
    
    When underlying dissectors exceed MAX_TREE_ITEMS, the frame dissector
    will fail when adding more items. We make room for the following items
    by decrementing the count for the current tree before adding them.
    
    This change will fix all errors where underlying dissectors add MAX_TREE_ITEMS
    items to the tree.
    
    Bug: 15448
    Change-Id: I03f3191cf1b737ac9ab569fbe5bf77f3a30e2401
    Reviewed-on: https://code.wireshark.org/review/31975
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 620acf58b9b81890d510939da91c7d9686bcf2c3)
    Reviewed-on: https://code.wireshark.org/review/32006
    

Actions performed:

    from  83fc0fd   CMake: disable relocatable builds when dumpcap is being built
     add  518d267   frame: fix crash when dissectors add the maximum number of tree items.


Summary of changes:
 epan/dissectors/packet-frame.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)