Wireshark-commits: [Wireshark-commits] master f54a625: CMake: clear cache variables when a library
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 11 Feb 2019 05:06:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f54a6256820b96ad6d34955e87f7897d77d46983
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f54a625 by Peter Wu (peter@xxxxxxxxxxxxx):

    CMake: clear cache variables when a library has changed
    
    On Windows, whenever win-setup.ps1 installs new libraries, the old
    paths become invalid. As a workaround the user can remove CMakeCache.txt
    completely or manually delete entries. Removing the whole file might
    lose custom options and clearing individual entries is tedious. Let's
    handle this automatically.
    
    Some HAVE_xxx variables from check_function_exists calls in PCAP and
    ZLIB, and one from check_symbol_exists in KERBEROS are not cleared.
    Those special cases would require too much work, the user should
    manually clear their cache in this case if needed.
    
    Fixes my local build since CARES, KERBEROS and LibXml2 were updated.
    Special care was necessary for LibXml2 as it will not set cache variable
    LIBXML2_LIBRARY when LIBXML2_LIBRARIES is already set.
    
    Change-Id: Ic793bdb67161504aadadf221bd7740a0ca31db63
    Link: https://www.wireshark.org/lists/wireshark-dev/201902/msg00028.html
    Reviewed-on: https://code.wireshark.org/review/31960
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  203839d   CMake: remove unused FindMACOS_FRAMEWORKS.cmake file
     add  f54a625   CMake: clear cache variables when a library has changed


Summary of changes:
 CMakeLists.txt | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)