Wireshark-commits: [Wireshark-commits] master 720c3bd: column: set G_REGEX_RAW for the custom colum
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 10 Feb 2019 16:13:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=720c3bdc04621cc9aacee3d1ff15454ba81b9695
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

720c3bd by Peter Wu (peter@xxxxxxxxxxxxx):

    column: set G_REGEX_RAW for the custom column filter
    
    Neither the pattern nor the intended subject (a custom fields filter)
    contain UTF-8, so set G_REGEX_RAW accordingly. While a filter such as
    `tcp matches "foo\xff"` (with `\xff` being a single byte) was accepted,
    it did not trigger a crash though even if the precondition was violated.
    
    Change-Id: I45d76b9abbd942d186dcf70f581121769bbd2d0a
    Ping-Bug: 14905
    Reviewed-on: https://code.wireshark.org/review/31940
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  567fe96   extcap: set G_REGEX_RAW to avoid potential crashes
     add  720c3bd   column: set G_REGEX_RAW for the custom column filter


Summary of changes:
 epan/column-utils.c | 3 ++-
 epan/column.c       | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)