Wireshark-commits: [Wireshark-commits] master-3.0 4d57011: make-version.pl: Fix version variable ch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 Feb 2019 23:21:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4d57011da844bceefd6df807984fe74906a3f6d7
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

4d57011 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    make-version.pl: Fix version variable checks.
    
    Use "defined" instead of checking the variable's value (which might
    be zero).
    
    Change-Id: Id24aa25971f73526761c9821846ac0abcf252978
    Reviewed-on: https://code.wireshark.org/review/31882
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 3b0b0cdb18c04b217497c84e20326c394c051808)
    Reviewed-on: https://code.wireshark.org/review/31883
    

Actions performed:

    from  cdfc56b   Qt: Add missing main menu mnemonics.
     add  4d57011   make-version.pl: Fix version variable checks.


Summary of changes:
 tools/make-version.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)