Wireshark · Wireshark-commits: [Wireshark-commits] master cdfc56b: Qt: Add missing main menu mnemonics.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cdfc56b340a8120c9766b75a70f2af231609c4ac
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

cdfc56b by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Add missing main menu mnemonics.
    
    The GTK+ main menu had quite a few keyboard mnemonics which were missing
    in the Qt UI, most notably File → Open, File → Close, and File → Quit.
    Update ui/qt/main_window.ui from a list generated by running
    
    `grep -E 'NULL, +".*_.*"' ui/gtk/main_menubar.c`
    
    in a current master-2.6 checkout.
    
    BTW, the proper terminology to use here is unclear. Most places use
    "mnemonics":
    
    GTK+: Access keys
    https://developer.gnome.org/hig/stable/keyboard-input.html.en
    
    Qt: Mnemonics or accelerator keys
    http://doc.qt.io/qt-5/qkeysequence.html
    http://doc.qt.io/qt-5/accelerators.html
    
    Wikipedia: Mnemonics
    https://en.wikipedia.org/wiki/Keyboard_shortcut
    
    Windows: Menu access keys or mnemonics
    https://docs.microsoft.com/en-us/windows/desktop/menurc/about-menus
    
    Bug: 15475
    Change-Id: Ibacbe066d4acfcea91125a980977d1610e3c0908
    Reviewed-on: https://code.wireshark.org/review/31871
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bfceb99   ua3g: add support for decoding of set-appl-param (id, enable, url) message
     add  cdfc56b   Qt: Add missing main menu mnemonics.


Summary of changes:
 ui/qt/main_window.ui | 58 ++++++++++++++++++++++++++--------------------------
 1 file changed, 29 insertions(+), 29 deletions(-)