Wireshark-commits: [Wireshark-commits] master 23a1b08: ftypes: make conversion of FT_DOUBLE to stri
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 Feb 2019 17:37:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=23a1b085ff3a0145ff6fd49eedfab6999704932a
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

23a1b08 by Peter Wu (peter@xxxxxxxxxxxxx):

    ftypes: make conversion of FT_DOUBLE to string locale-independent
    
    Use a locale-independent glib routine to format floating point numbers.
    This avoids displaying floating point numbers as "86399,9921875" with
    LC_ALL=nl_NL.UTF-8.
    
    This output is consistent with val_from_unparsed which is used for
    parsing display filter values and is already locale-independent. Note
    that the displayed node labels in the dissection tree is still
    locale-dependent (see proto_item_fill_label for FT_DOUBLE).
    
    Bug: 15437
    Change-Id: I64dd2b7dbb453022edf88b3052e2f67066189427
    Reviewed-on: https://code.wireshark.org/review/31869
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  e71715d   ZigBee: Dissect Metering cluster Get Profile Response
     add  23a1b08   ftypes: make conversion of FT_DOUBLE to string locale-independent


Summary of changes:
 epan/ftypes/ftype-double.c | 36 +++++++++++++++++-------------------
 1 file changed, 17 insertions(+), 19 deletions(-)