Wireshark-commits: [Wireshark-commits] master-2.4 064b81a: Also check whether we have nothing but D
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 31 Jan 2019 09:00:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=064b81a86b880defa32f122693fdae08473d9796
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

064b81a by Guy Harris (guy@xxxxxxxxxxxx):

    Also check whether we have nothing but DLCI bytes.
    
    The two failure modes are 1) no byte has the low-order bit set, so we
    didn't even find the end of the DLCI or 2) the byte at the end of the
    packet has the low-order bit set, so that it's all DLCI with no control
    byte after it.
    
    Expand a comment.
    
    Bug: 15463
    Change-Id: Ib76686391213dd56c06d665aa87a188621fe6816
    Reviewed-on: https://code.wireshark.org/review/31828
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit b5817dbda7de860e8e89cca5d1217d948c065259)
    Reviewed-on: https://code.wireshark.org/review/31830
    

Actions performed:

    from  fd34a91   Check whether you've hit the end of the packet data before going further.
     add  064b81a   Also check whether we have nothing but DLCI bytes.


Summary of changes:
 wiretap/ngsniffer.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)