Wireshark-commits: [Wireshark-commits] master f66cb9f: Qt: move method to apply/undo UAT changes to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 Jan 2019 23:33:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f66cb9f7efa7b230de211d8d0ff54c1d0213933d
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f66cb9f by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: move method to apply/undo UAT changes to UatModel
    
    UatModel could be constructed with a name instead of an epan_uat type.
    To allow those users to save/revert the uat, make sure to expose a
    method that does not require access to the underlying epan_uat type.
    
    Change-Id: I1d1a5811c1025bd9c2a2ea1722f460e6ac33b9aa
    Reviewed-on: https://code.wireshark.org/review/31793
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  58ffb7c   Qt: Fix memory leak of QMenu.
     add  f66cb9f   Qt: move method to apply/undo UAT changes to UatModel


Summary of changes:
 ui/qt/io_graph_dialog.cpp  | 19 +++++++------------
 ui/qt/models/uat_model.cpp | 37 +++++++++++++++++++++++++++++++++++++
 ui/qt/models/uat_model.h   | 17 +++++++++++++++++
 ui/qt/uat_dialog.cpp       | 37 +++++++++++++++++++------------------
 ui/qt/uat_frame.cpp        | 31 ++++++++++---------------------
 5 files changed, 90 insertions(+), 51 deletions(-)