Wireshark-commits: [Wireshark-commits] master-2.6 0f60296: Once we've identified a TCP segment as r
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 Jan 2019 20:02:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0f60296846e46c2e2d7021cca95b97a0533a6831
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

0f60296 by Guy Harris (guy@xxxxxxxxxxxx):

    Once we've identified a TCP segment as rpcap, use rpcap for the connection.
    
    One reason to use Wireshark is to diagnose protocol errors, so don't,
    for example, treat too-short packets, in a TCP connection where we've
    already seen rpcap packets, as not being rpcap packets.  (Yes, that *is*
    a bug, in the libpcap master, that I found and fixed.)
    
    Change-Id: I9a81e5b9a2910331574164395302247a446e805b
    Reviewed-on: https://code.wireshark.org/review/31809
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 2876f57f28debaa916c91707d1772e686d645b74)
    Reviewed-on: https://code.wireshark.org/review/31810
    

Actions performed:

    from  b417499   Further improve that error message.
     add  0f60296   Once we've identified a TCP segment as rpcap, use rpcap for the connection.


Summary of changes:
 epan/dissectors/packet-rpcap.c | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)