Wireshark-commits: [Wireshark-commits] master-2.6 ee691f3: ISAKMP: fix memory leaks for IKEv1 decry
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 26 Jan 2019 13:31:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee691f3889e8a77abb3b2f36ce1d4fe4a909d5a1
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

ee691f3 by Peter Wu (peter@xxxxxxxxxxxxx):

    ISAKMP: fix memory leaks for IKEv1 decryption
    
    Fixes leaks of allocations from dissect_key_exch as detected by ASAN
    while running the following tests:
    
        test_ikev1_simultaneous
        test_ikev1_unencrypted
        test_text2pcap_ikev1_certs_pcap
        test_ikev1_certs
    
    Change-Id: Ifc102539efadd33d1b9d9921bcdbb35dfd31927f
    Fixes: acfe071eb6 ("Add decryption support.")
    Reviewed-on: https://code.wireshark.org/review/31740
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit ae6b585d518c56c5daa0243796c6321643e68ed7)
    Reviewed-on: https://code.wireshark.org/review/31749
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  fc75a91   ETSI CAT: do not call tvb_bytes_to_str() with a 0 length
     add  ee691f3   ISAKMP: fix memory leaks for IKEv1 decryption


Summary of changes:
 epan/dissectors/packet-isakmp.c | 2 ++
 1 file changed, 2 insertions(+)