Wireshark-commits: [Wireshark-commits] master 0b9b531: tcp: fix reporting of "Reassembled in" for O
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 25 Jan 2019 12:01:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b9b531726d5b18ab1ef9d071a312a3c578743e3
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

0b9b531 by Peter Wu (peter@xxxxxxxxxxxxx):

    tcp: fix reporting of "Reassembled in" for OoO initial segment
    
    When the initial segment is OoO, it was recognized as retransmitted. Fix
    this by remembering which frame actually contains the initial segment.
    
    Bug: 15420
    Change-Id: If63e2ff581775ff9d396a612839f1bfab30f111f
    Reviewed-on: https://code.wireshark.org/review/31720
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  394e391   pfcp: Improved printout on some IEs
     add  0b9b531   tcp: fix reporting of "Reassembled in" for OoO initial segment


Summary of changes:
 epan/dissectors/packet-tcp.c |  30 ++++++++++++++++++++++--------
 epan/dissectors/packet-tcp.h |   4 +++-
 test/captures/http-ooo2.pcap | Bin 0 -> 536 bytes
 test/suite_dissection.py     |  34 ++++++++++++++++++++++++++++++++++
 4 files changed, 59 insertions(+), 9 deletions(-)
 create mode 100644 test/captures/http-ooo2.pcap