Wireshark-commits: [Wireshark-commits] master bf208ab: smb2: add NULL checks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 24 Jan 2019 18:38:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bf208ab000857fe8d89393542ebd963a43b3db91
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

bf208ab by Aurelien Aptel (aaptel@xxxxxxxx):

    smb2: add NULL checks
    
    in incomplete traces, the saved packet data (ssi) might be NULL. This
    would trigger segfaults.
    
    Sample problematic capture:
    
    https://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=get&target=smb-on-windows-10.pcapng
    
    Change-Id: I3e40efa34396d2ffe5bd75fb4250c7ccf0cb6b93
    Reviewed-on: https://code.wireshark.org/review/31722
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  5576072   EPL: fix build with incomplete libxml2 library
     add  bf208ab   smb2: add NULL checks


Summary of changes:
 epan/dissectors/packet-smb2.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)