Wireshark-commits: [Wireshark-commits] master 044a9de: tvbuff: Fix RFC 822 and 1123 date parsing wi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 24 Jan 2019 09:19:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=044a9deeca90dfe61754c06d623272f87c9e140f
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

044a9de by Peter Wu (peter@xxxxxxxxxxxxx):

    tvbuff: Fix RFC 822 and 1123 date parsing with non-English locales
    
    Avoid relying on strptime to parse the day of week (%a) and month name
    (%b) since these are locale-dependent. Fixes test suite failures with
    tvb.lua and LC_ALL=nl_NL.UTF-8.
    
    Additionally it will now reject four-digit years when using ENC_RFC_822
    as that requires two digit years. The only user of this API seems to be
    the Lua tests though, so this should not make much of a difference.
    
    Bug: 15437
    Change-Id: I75436b93faab23869794d9756b9c3ce6128dd1f4
    Reviewed-on: https://code.wireshark.org/review/31698
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  4f8b3f3   By default, don't stop after a read error.
     add  044a9de   tvbuff: Fix RFC 822 and 1123 date parsing with non-English locales


Summary of changes:
 epan/tvbuff.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 50 insertions(+), 13 deletions(-)