Wireshark-commits: [Wireshark-commits] master d4913bd: SDP: fix memleak of "trace_id"
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Jan 2019 20:15:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d4913bd5ba95ac1576139c46d09b402435c0b557
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d4913bd by Peter Wu (peter@xxxxxxxxxxxxx):

    SDP: fix memleak of "trace_id"
    
    The string value is stored in the conversation, so use file-scoped
    memory instead of g_strdup. Convert to union to save space.
    
    Bug: 15440
    Change-Id: Ie2dabfc67ac1db1cc8f864601b8395dcdec7caf8
    Fixes: v2.9.0rc0-2719-g8bd0616621 ("SDP: Show callid from all call legs with the same RTP cpnversation.")
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11845
    Reviewed-on: https://code.wireshark.org/review/31704
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e8f6a90   SMB2: fix memleak of tids hash table
     add  d4913bd   SDP: fix memleak of "trace_id"


Summary of changes:
 epan/dissectors/packet-megaco.c | 2 +-
 epan/dissectors/packet-rtp.c    | 8 ++++----
 epan/dissectors/packet-sdp.c    | 4 ++--
 epan/dissectors/packet-sdp.h    | 6 ++++--
 epan/dissectors/packet-sip.c    | 2 +-
 5 files changed, 12 insertions(+), 10 deletions(-)